8386473: DESKeySpec and DESedeKeySpec may throw InvalidKeyException instead of ArrayIndexOutOfBoundsException for Integer.MIN_VALUE offset by smemery · Pull Request #31494 · openjdk/jdk

smemery · 2026-06-12T00:48:00Z

This fix includes throwing the correct exception when an offset for the key length check would cause an integer overflow therefore throwing the wrong exception.

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8386473: DESKeySpec and DESedeKeySpec may throw InvalidKeyException instead of ArrayIndexOutOfBoundsException for Integer.MIN_VALUE offset (Bug - P2)

Reviewers

Sean Mullan (@seanjmullan - Reviewer)
SendaoYan (@sendaoYan - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31494/head:pull/31494
$ git checkout pull/31494

Update a local copy of the PR:
$ git checkout pull/31494
$ git pull https://git.openjdk.org/jdk.git pull/31494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31494

View PR using the GUI difftool:
$ git pr show -t 31494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31494.diff

Using Webrev

Link to Webrev Comment

…nstead of ArrayIndexOutOfBoundsException for Integer.MIN_VALUE offset

bridgekeeper · 2026-06-12T00:49:15Z

👋 Welcome back semery! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-06-12T00:50:31Z

@smemery This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8386473: DESKeySpec and DESedeKeySpec may throw InvalidKeyException instead of ArrayIndexOutOfBoundsException for Integer.MIN_VALUE offset

Reviewed-by: mullan, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 213 new commits pushed to the master branch:

96513c3: 8381236: VoiceOver Fails to Identify Component After Switching Windows
33a49d1: 8386681: Remove RawKeySpec
0bf930d: 8386604: GenShen: _do_old_gc_bootstrap could become stuck after a full GC
... and 210 more: https://git.openjdk.org/jdk/compare/114e3c61060752e34f7a075318ea7d2cff40744b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan, @sendaoYan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2026-06-12T00:51:17Z

@smemery The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2026-06-12T00:55:20Z

Webrevs

01: Full - Incremental (846a6927)
00: Full (bb25897d)

smemery · 2026-06-12T18:33:10Z

/integrate

openjdk · 2026-06-12T18:33:58Z

@smemery
Your change (at version bb25897) is now ready to be sponsored by a Committer.

sendaoYan · 2026-06-13T08:36:26Z

+            boolean weak = DESKeySpec.isWeak(strongKey, Integer.MIN_VALUE);
+            throw new Exception("expected ArrayIndexOutOfBoundsException");
+        } catch (ArrayIndexOutOfBoundsException aiobe) {}
+        try{


There are several try{ missed a whitespace

Fixed in latest delta.

sendaoYan · 2026-06-13T08:37:22Z

- * @summary DESKeySpec.isWeak should throw aiobe exception if the offset is
- * negative.
+ * @bug 8364121 8386473
+ * @summary Test DES[ede]KeySpec for negative and integer overflow offsets
 */
 import java.security.InvalidKeyException;


'import InvalidKeyException' seems useless.

Good catch, removed.

smemery · 2026-06-14T03:30:13Z

/integrate

openjdk · 2026-06-14T03:31:09Z

@smemery This pull request has not yet been marked as ready for integration.

smemery · 2026-06-18T17:05:49Z

/integrate

openjdk · 2026-06-18T17:07:34Z

@smemery
Your change (at version 846a692) is now ready to be sponsored by a Committer.

seanjmullan · 2026-06-18T17:14:06Z

/sponsor

openjdk · 2026-06-18T17:16:26Z

Going to push as commit 1ad2db7.
Since your change was applied there have been 213 commits pushed to the master branch:

96513c3: 8381236: VoiceOver Fails to Identify Component After Switching Windows
33a49d1: 8386681: Remove RawKeySpec
0bf930d: 8386604: GenShen: _do_old_gc_bootstrap could become stuck after a full GC
... and 210 more: https://git.openjdk.org/jdk/compare/114e3c61060752e34f7a075318ea7d2cff40744b...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-06-18T17:16:42Z

@seanjmullan @smemery Pushed as commit 1ad2db7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

smemery · 2026-06-19T22:13:00Z

/backport :jdk27

openjdk · 2026-06-19T22:14:36Z

@smemery the backport was successfully created on the branch backport-smemery-1ad2db7a-jdk27 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk27, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 1ad2db7a from the openjdk/jdk repository.

The commit being backported was authored by Shawn Emery on 18 Jun 2026 and was reviewed by Sean Mullan and SendaoYan.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-smemery-1ad2db7a-jdk27:backport-smemery-1ad2db7a-jdk27
$ git checkout backport-smemery-1ad2db7a-jdk27
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-smemery-1ad2db7a-jdk27

⚠️ @smemery You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

smemery added 2 commits June 11, 2026 18:31

8386473: DESKeySpec and DESedeKeySpec may throw InvalidKeyException i…

5d707c0

…nstead of ArrayIndexOutOfBoundsException for Integer.MIN_VALUE offset

Fix test @bug annotation

bb25897

openjdk Bot added the security [email protected] label Jun 12, 2026

openjdk Bot added the rfr Pull request is ready for review label Jun 12, 2026

seanjmullan approved these changes Jun 12, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Jun 12, 2026

openjdk Bot added the sponsor Pull request is ready to be sponsored label Jun 12, 2026

sendaoYan reviewed Jun 13, 2026

View reviewed changes

Updates based on sendaoYan's comments

846a692

openjdk Bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Jun 13, 2026

sendaoYan approved these changes Jun 14, 2026

View reviewed changes

seanjmullan approved these changes Jun 18, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Jun 18, 2026

openjdk Bot added the sponsor Pull request is ready to be sponsored label Jun 18, 2026

openjdk Bot added the integrated Pull request has been integrated label Jun 18, 2026

openjdk Bot closed this Jun 18, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 18, 2026

Uh oh!

Conversation

smemery commented Jun 12, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented Jun 12, 2026

Uh oh!

openjdk Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

smemery commented Jun 12, 2026

Uh oh!

openjdk Bot commented Jun 12, 2026

Uh oh!

sendaoYan Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

smemery Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

sendaoYan Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

smemery Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

smemery commented Jun 14, 2026

Uh oh!

openjdk Bot commented Jun 14, 2026

Uh oh!

smemery commented Jun 18, 2026

Uh oh!

openjdk Bot commented Jun 18, 2026

Uh oh!

seanjmullan commented Jun 18, 2026

Uh oh!

openjdk Bot commented Jun 18, 2026

Uh oh!

openjdk Bot commented Jun 18, 2026

Uh oh!

smemery commented Jun 19, 2026

Uh oh!

openjdk Bot commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

smemery commented Jun 12, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Jun 12, 2026 •

edited

Loading

openjdk Bot commented Jun 12, 2026 •

edited

Loading

mlbridge Bot commented Jun 12, 2026 •

edited

Loading